[webkit-reviews] review denied: [Bug 222315] Enable WASM on Windows : [Attachment 467508] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 1 09:44:23 PDT 2023

Darin Adler <darin at apple.com> has denied Ian Grunert <ian.grunert at gmail.com>'s
request for review:
Bug 222315: Enable WASM on Windows

Attachment 467508: Patch


--- Comment #7 from Darin Adler <darin at apple.com> ---
Comment on attachment 467508
  --> https://bugs.webkit.org/attachment.cgi?id=467508

View in context: https://bugs.webkit.org/attachment.cgi?id=467508&action=review

>> Source/JavaScriptCore/wasm/WasmStreamingParser.cpp:-293
>> -	(void) dumpWasmSource;
> This does have an effect on non-Win builds, so you'll also need to add `&&
ASSERT_ENABLED` to the definition of dumpWasmSource.

Please post a new patch that fixes this issue.

More information about the webkit-reviews mailing list