[webkit-reviews] review granted: [Bug 263303] AX: Extremely long textareas/contenteditable fields are slow with Voiceover : [Attachment 468411] Patch

[bugzilla-daemon at webkit.org]

Tyler Wilcock <tyler_w at apple.com> has granted  review:
Bug 263303: AX: Extremely long textareas/contenteditable fields are slow with
Voiceover
https://bugs.webkit.org/show_bug.cgi?id=263303

Attachment 468411: Patch

https://bugs.webkit.org/attachment.cgi?id=468411&action=review




--- Comment #27 from Tyler Wilcock <tyler_w at apple.com> ---
Comment on attachment 468411
  --> https://bugs.webkit.org/attachment.cgi?id=468411
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=468411&action=review

> Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:162
> +    if ([clientString isEqualToString:@"VoiceOver"])
> +	   _AXSetClientIdentificationOverride(kAXClientTypeVoiceOver);

Might be nice to compare this case-insensitively:

[clientString caseInsensitiveCompare:@"voiceover"] == NSOrderedSame

> LayoutTests/accessibility/mac/spellcheck-with-voiceover.html:14
> +

Don't need a newline here (in my opinion).

> LayoutTests/accessibility/mac/spellcheck-with-voiceover.html:29
> +

Don't need a newline here (in my opinion).

> LayoutTests/accessibility/mac/spellcheck-with-voiceover.html:31
> +

Don't need a newline here (in my opinion).