[webkit-reviews] review granted: [Bug 263403] AX: AXIsolatedTree::createEmptyContent takes too long. : [Attachment 468304] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 23 14:24:23 PDT 2023


Tyler Wilcock <tyler_w at apple.com> has granted Andres Gonzalez
<andresg_22 at apple.com>'s request for review:
Bug 263403: AX: AXIsolatedTree::createEmptyContent takes too long.
https://bugs.webkit.org/show_bug.cgi?id=263403

Attachment 468304: Patch

https://bugs.webkit.org/attachment.cgi?id=468304&action=review




--- Comment #6 from Tyler Wilcock <tyler_w at apple.com> ---
Comment on attachment 468304
  --> https://bugs.webkit.org/attachment.cgi?id=468304
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=468304&action=review

> Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h:369
> +    bool m_emptyContentTree { false };

Thoughts on m_isEmptyContentTree to match the member function, and to satisfy
the style guide?

https://webkit.org/code-style-guidelines/#names-bool

> Precede boolean values with words like “is” and “did”.


More information about the webkit-reviews mailing list