[webkit-reviews] review granted: [Bug 262418] AX: Expose LabeledBy relationships unconditionally. : [Attachment 468032] Patch

[bugzilla-daemon at webkit.org]

Tyler Wilcock <tyler_w at apple.com> has granted Andres Gonzalez
<andresg_22 at apple.com>'s request for review:
Bug 262418: AX: Expose LabeledBy relationships unconditionally.
https://bugs.webkit.org/show_bug.cgi?id=262418

Attachment 468032: Patch

https://bugs.webkit.org/attachment.cgi?id=468032&action=review




--- Comment #6 from Tyler Wilcock <tyler_w at apple.com> ---
Comment on attachment 468032
  --> https://bugs.webkit.org/attachment.cgi?id=468032
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=468032&action=review

> COMMIT_MESSAGE:7
> +In COCOA platforms, we had the constraint of only exposing the LabeledBy
relationship via the TitleUIElement property under certain conditions. This
restriction is no longer needed in most situations and this patch removes it.
The exception is when the Element has an aria-label attribute, in whic case we
still return null TitleUIElement to force clients to use the aria-label .

Extra space before the period here.

to force clients to use the aria-label .

Also typo on whic

> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:253
> +    // We impose the restriction that if there is more than one label
element for the given Node, then should return none.

Missing a word here I think.

then should return none vs. then we should return none.