[webkit-reviews] review granted: [Bug 262410] [IFC][Cleanup] InlineFormattingContext should construct/own InlineLayoutState : [Attachment 467987] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted  review:
Bug 262410: [IFC][Cleanup] InlineFormattingContext should construct/own
InlineLayoutState
https://bugs.webkit.org/show_bug.cgi?id=262410

Attachment 467987: Patch

https://bugs.webkit.org/attachment.cgi?id=467987&action=review




--- Comment #4 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 467987
  --> https://bugs.webkit.org/attachment.cgi?id=467987
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=467987&action=review

nice!

> Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:771
> +    if (auto adjustedRect =
InlineFormattingQuirks::adjustedRectForLineGridLineAlign(constraints.logicalRec
t, formattingContext().root().style(), inlineLayoutState()))
>	   constraints.logicalRect = *adjustedRect;

adjustedRectForLineGridLineAlign can now be turned non-static and called via
formattingContext().formattingQuirks(). Then it will only need the
constraints.logicalRect parameter.