[webkit-reviews] review granted: [Bug 265434] AX: TextInputMarkedTextMarkerRange should be cached during initialization : [Attachment 468781] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 28 00:09:49 PST 2023


Tyler Wilcock <tyler_w at apple.com> has granted  review:
Bug 265434: AX: TextInputMarkedTextMarkerRange should be cached during
initialization
https://bugs.webkit.org/show_bug.cgi?id=265434

Attachment 468781: Patch

https://bugs.webkit.org/attachment.cgi?id=468781&action=review




--- Comment #3 from Tyler Wilcock <tyler_w at apple.com> ---
Comment on attachment 468781
  --> https://bugs.webkit.org/attachment.cgi?id=468781
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=468781&action=review

> LayoutTests/accessibility/mac/text-input-marked-range.html:27
> +    })

For consistency, maybe we add a semicolon here?

> LayoutTests/accessibility/mac/text-input-marked-text-marker-range.html:25
> +	   await waitFor(() => {
> +	       text =
element.stringForTextMarkerRange(element.textInputMarkedTextMarkerRange());
> +	       return text == "test";
> +	   });
> +	   output += await expectAsync("text", "'test'");

Can this be shortened to:

output += await
expectAsync("element.stringForTextMarkerRange(element.textInputMarkedTextMarker
Range())", "test");

> LayoutTests/accessibility/mac/text-input-marked-text-marker-range.html:32
> +	   await waitFor(() => {
> +	       text =
element.stringForTextMarkerRange(element.textInputMarkedTextMarkerRange());
> +	       return !text;
> +	   });
> +	   output += await expectAsync("!text", "true");

Can this be shortened to:

output += await
expectAsync("!element.stringForTextMarkerRange(element.textInputMarkedTextMarke
rRange())", "true");

> LayoutTests/accessibility/mac/text-input-marked-text-marker-range.html:40
> +	   textInputController.setMarkedText(" message", 4, " message".length);
> +	   await waitFor(() => {
> +	       text =
element.stringForTextMarkerRange(element.textInputMarkedTextMarkerRange());
> +	       return text == " message";
> +	   });
> +	   output += expect("text", "' message'");

Can we use await expectAsync here too?

> LayoutTests/accessibility/mac/text-input-marked-text-marker-range.html:45
> +    })

For consistency, maybe we add a semicolon after this parentheses?


More information about the webkit-reviews mailing list