[webkit-reviews] review granted: [Bug 265166] [IFC] Pre-compute "content has strong directionality character" bit : [Attachment 468695] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted  review:
Bug 265166: [IFC] Pre-compute "content has strong directionality character" bit
https://bugs.webkit.org/show_bug.cgi?id=265166

Attachment 468695: Patch

https://bugs.webkit.org/attachment.cgi?id=468695&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 468695
  --> https://bugs.webkit.org/attachment.cgi?id=468695
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=468695&action=review

> Source/WebCore/layout/layouttree/LayoutInlineTextBox.cpp:37
> +InlineTextBox::InlineTextBox(String content, bool isCombined,
WTF::OptionSet<ContentCharacteristic> contentCharacteristicSet, RenderStyle&&
style, std::unique_ptr<RenderStyle>&& firstLineStyle)

no need to say WTF::

> Source/WebCore/layout/layouttree/LayoutInlineTextBox.h:45
> +    InlineTextBox(String, bool isCombined,
WTF::OptionSet<ContentCharacteristic>, RenderStyle&&,
std::unique_ptr<RenderStyle>&& firstLineStyle = nullptr);

(anywhere)