[webkit-reviews] review granted: [Bug 256410] overflow:clip fails when intrusive float is present : [Attachment 466348] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 15 15:05:52 PDT 2023


Simon Fraser (smfr) <simon.fraser at apple.com> has granted  review:
Bug 256410: overflow:clip fails when intrusive float is present
https://bugs.webkit.org/show_bug.cgi?id=256410

Attachment 466348: Patch

https://bugs.webkit.org/attachment.cgi?id=466348&action=review




--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 466348
  --> https://bugs.webkit.org/attachment.cgi?id=466348
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=466348&action=review

> Source/WebCore/rendering/FloatingObjects.cpp:56
> +    , m_overflowClippedByAncestor(false)

maybe `m_hasAncestorWithOverflowClip`. Also, we can initialize bitfield members
with initializers now.


More information about the webkit-reviews mailing list