[webkit-reviews] review granted: [Bug 256598] AX: Cache relative frame for ScrollView and WebArea during page load in the IsolatedObject. : [Attachment 466308] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 10 11:45:07 PDT 2023


Tyler Wilcock <tyler_w at apple.com> has granted Andres Gonzalez
<andresg_22 at apple.com>'s request for review:
Bug 256598: AX: Cache relative frame for ScrollView and WebArea during page
load in the IsolatedObject.
https://bugs.webkit.org/show_bug.cgi?id=256598

Attachment 466308: Patch

https://bugs.webkit.org/attachment.cgi?id=466308&action=review




--- Comment #3 from Tyler Wilcock <tyler_w at apple.com> ---
Comment on attachment 466308
  --> https://bugs.webkit.org/attachment.cgi?id=466308
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=466308&action=review

> Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:177
> +	   setProperty(AXPropertyName::RelativeFrame, IntRect {
object.relativeFrame() });

We use `enclosingIntRect(...)` when caching the paint rects, so let's use that
over IntRect { ... } here too.


More information about the webkit-reviews mailing list