[webkit-reviews] review granted: [Bug 256537] [Repaint] Cleanup RenderElement::repaintAfterLayoutIfNeeded : [Attachment 466297] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 9 14:07:59 PDT 2023
Simon Fraser (smfr) <simon.fraser at apple.com> has granted review:
Bug 256537: [Repaint] Cleanup RenderElement::repaintAfterLayoutIfNeeded
https://bugs.webkit.org/show_bug.cgi?id=256537
Attachment 466297: Patch
https://bugs.webkit.org/attachment.cgi?id=466297&action=review
--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 466297
--> https://bugs.webkit.org/attachment.cgi?id=466297
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=466297&action=review
> Source/WebCore/rendering/RenderElement.cpp:1287
> + auto width = absoluteValue(newOutlineAndBoxShadowBox.width() -
oldOutlineAndBoxShadowBox.width());
Nicer to compute a size delta (with "delta" in the name).
More information about the webkit-reviews
mailing list