[webkit-reviews] review granted: [Bug 256288] AX: Build the isolated tree asynchroniously. : [Attachment 466217] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 5 11:14:01 PDT 2023

Tyler Wilcock <tyler_w at apple.com> has granted Andres Gonzalez
<andresg_22 at apple.com>'s request for review:
Bug 256288: AX: Build the isolated tree asynchroniously.

Attachment 466217: Patch


--- Comment #7 from Tyler Wilcock <tyler_w at apple.com> ---
Comment on attachment 466217
  --> https://bugs.webkit.org/attachment.cgi?id=466217

View in context: https://bugs.webkit.org/attachment.cgi?id=466217&action=review

> Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:130
> +    treePageCache().set(*axObjectCache->pageID(), tree.copyRef());

Ref::copyRef was deprecated here:


You might just be able to use the implicit copy-constructor here?

More information about the webkit-reviews mailing list