[webkit-reviews] review granted: [Bug 256268] [LFC][Floating] LineBuilder shouldn't mutate float box geometry : [Attachment 466198] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 4 08:44:22 PDT 2023


Antti Koivisto <koivisto at iki.fi> has granted  review:
Bug 256268: [LFC][Floating] LineBuilder shouldn't mutate float box geometry
https://bugs.webkit.org/show_bug.cgi?id=256268

Attachment 466198: Patch

https://bugs.webkit.org/attachment.cgi?id=466198&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 466198
  --> https://bugs.webkit.org/attachment.cgi?id=466198
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=466198&action=review

>
Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp:433
> +	   for (auto floatItem : intrinsicContent.placedFloats)

why copy?


More information about the webkit-reviews mailing list