[webkit-reviews] review granted: [Bug 256207] AX: Avoid hitting the main thread to retrieve position and size of WKAccessibilityWebPageObjects in isolated tree mode. : [Attachment 466181] Patch

[bugzilla-daemon at webkit.org]

Tyler Wilcock <tyler_w at apple.com> has granted Andres Gonzalez
<andresg_22 at apple.com>'s request for review:
Bug 256207: AX: Avoid hitting the main thread to retrieve position and size of
WKAccessibilityWebPageObjects in isolated tree mode.
https://bugs.webkit.org/show_bug.cgi?id=256207

Attachment 466181: Patch

https://bugs.webkit.org/attachment.cgi?id=466181&action=review




--- Comment #10 from Tyler Wilcock <tyler_w at apple.com> ---
Comment on attachment 466181
  --> https://bugs.webkit.org/attachment.cgi?id=466181
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=466181&action=review

> Source/WebCore/loader/EmptyFrameLoaderClient.h:183
> +    void setAXIsolatedTreeRoot(WebCore::AXCoreObject*) final;

This should always be an AXIsolatedObject*, right? Typing this as AXCoreObject
implicitly means "this could be an AccessibilityObject or an AXIsolatedObject",
which seems wrong — the AXIsolatedTreeRoot should never be an
AccessibilityObject.