[webkit-reviews] review granted: [Bug 256183] Update leading-trim (to text-box-trim) to match the latest spec : [Attachment 466162] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 1 16:46:01 PDT 2023
Tim Nguyen (:ntim) <ntim at apple.com> has granted review:
Bug 256183: Update leading-trim (to text-box-trim) to match the latest spec
https://bugs.webkit.org/show_bug.cgi?id=256183
Attachment 466162: Patch
https://bugs.webkit.org/attachment.cgi?id=466162&action=review
--- Comment #2 from Tim Nguyen (:ntim) <ntim at apple.com> ---
Comment on attachment 466162
--> https://bugs.webkit.org/attachment.cgi?id=466162
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=466162&action=review
text-edge needs to be renamed to text-box-edge too, but I guess this can be a
separate patch
> Source/WebCore/css/CSSPrimitiveValueMappings.h:574
> #define FOR_EACH(CASE) CASE(Normal) CASE(Start) CASE(End) CASE(Both)
The initial value is now "none" instead of "normal".
> Source/WebCore/css/CSSProperties.json:3793
> "normal",
same here
> Source/WebCore/rendering/style/RenderStyleConstants.h:690
> Normal,
same here
More information about the webkit-reviews
mailing list