[webkit-reviews] review granted: [Bug 254675] [Margin-trim] Remove a virtual function call on this rare property while computing margins : [Attachment 465667] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 29 12:08:21 PDT 2023


Chris Dumez <cdumez at apple.com> has granted zalan <zalan at apple.com>'s request
for review:
Bug 254675: [Margin-trim] Remove a virtual function call on this rare property
while computing margins
https://bugs.webkit.org/show_bug.cgi?id=254675

Attachment 465667: Patch

https://bugs.webkit.org/attachment.cgi?id=465667&action=review




--- Comment #6 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 465667
  --> https://bugs.webkit.org/attachment.cgi?id=465667
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=465667&action=review

r=me

> Source/WebCore/rendering/RenderBox.h:313
> +    bool shouldTrimChildMargin(MarginTrimType, const RenderBox&) const;

This can likely be protected.


More information about the webkit-reviews mailing list