[webkit-reviews] review granted: [Bug 254374] REGRESSION (260451 at main): Opening any PDF in WebKit opens it halfway down the first page : [Attachment 465558] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 23 15:55:01 PDT 2023


Tim Horton <thorton at apple.com> has granted  review:
Bug 254374: REGRESSION (260451 at main): Opening any PDF in WebKit opens it
halfway down the first page
https://bugs.webkit.org/show_bug.cgi?id=254374

Attachment 465558: Patch

https://bugs.webkit.org/attachment.cgi?id=465558&action=review




--- Comment #4 from Tim Horton <thorton at apple.com> ---
Comment on attachment 465558
  --> https://bugs.webkit.org/attachment.cgi?id=465558
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=465558&action=review

> Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:455
> +    callOnMainRunLoopAndWait([protectedPlugin = Ref { *_pdfPlugin },
newPosition] {

What thread are we actually on, and are we sure the main thread will never be
waiting on *us*?


More information about the webkit-reviews mailing list