[webkit-reviews] review granted: [Bug 253752] AX: -[WebAccessibilityObjectWrapperMac attachmentView] should only be called when needed : [Attachment 465390] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 10 19:56:37 PST 2023


chris fleizach <cfleizach at apple.com> has granted  review:
Bug 253752: AX: -[WebAccessibilityObjectWrapperMac attachmentView] should only
be called when needed
https://bugs.webkit.org/show_bug.cgi?id=253752

Attachment 465390: Patch

https://bugs.webkit.org/attachment.cgi?id=465390&action=review




--- Comment #3 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 465390
  --> https://bugs.webkit.org/attachment.cgi?id=465390
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=465390&action=review

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:3830
> +	       }

I think we can get rid of the isAttschment variable and just use whether
attachmentView is nil

AddObject: attachmentView ?: wrapper


More information about the webkit-reviews mailing list