[webkit-reviews] review granted: [Bug 258249] [FFC] FlexLayout::computeAvailableMainAndCrossSpace should follow spec language : [Attachment 466737] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted  review:
Bug 258249: [FFC] FlexLayout::computeAvailableMainAndCrossSpace should follow
spec language
https://bugs.webkit.org/show_bug.cgi?id=258249

Attachment 466737: Patch

https://bugs.webkit.org/attachment.cgi?id=466737&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 466737
  --> https://bugs.webkit.org/attachment.cgi?id=466737
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=466737&action=review

> Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp:131
> +    auto computeFinalSize = [&](auto& candidateSizes, auto& finalSize) {

wouldn't it be cleaner to just return the finalSize?