[webkit-reviews] review granted: [Bug 257739] AX: AXObjectCache::setIsolatedTreeFocusedObject should handle the same special cases as focusedObjectForPage. : [Attachment 466604] Patch

[bugzilla-daemon at webkit.org]

Tyler Wilcock <tyler_w at apple.com> has granted Andres Gonzalez
<andresg_22 at apple.com>'s request for review:
Bug 257739: AX: AXObjectCache::setIsolatedTreeFocusedObject should handle the
same special cases as focusedObjectForPage.
https://bugs.webkit.org/show_bug.cgi?id=257739

Attachment 466604: Patch

https://bugs.webkit.org/attachment.cgi?id=466604&action=review




--- Comment #7 from Tyler Wilcock <tyler_w at apple.com> ---
Comment on attachment 466604
  --> https://bugs.webkit.org/attachment.cgi?id=466604
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=466604&action=review

Thanks for doing this!

>
LayoutTests/accessibility/active-descendant-changes-result-in-focus-changes.htm
l:23
> +	   await waitFor(() =>
accessibilityController.focusedElement.domIdentifier == "listbox");
> +	   output +=
expect("accessibilityController.focusedElement.domIdentifier", "'listbox'");

Nit for future patches, not worth changing for this one.

This can be written more succinctly using expectAsync.

output += await
expectAsync("accessibilityController.focusedElement.domIdentifier",
"'listbox'");