[webkit-reviews] review granted: [Bug 132188] <textarea> with float:left disappears when editing text : [Attachment 466589] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 6 12:57:08 PDT 2023

Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 132188: <textarea> with float:left disappears when editing text

Attachment 466589: Patch


--- Comment #14 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 466589
  --> https://bugs.webkit.org/attachment.cgi?id=466589

View in context: https://bugs.webkit.org/attachment.cgi?id=466589&action=review

> +4. However self-paining float boxes always paint themselves (this is not
specific to floats, all renderers behave like this).


> Source/WebCore/rendering/RenderBox.cpp:5722
> +void RenderBox::updateFloatBoxAfterSelfPaintingLayerChange()

"update float box" makes it sound like this is changing the float box itself.
Maybe "updateFloatPainter..."?

More information about the webkit-reviews mailing list