[webkit-reviews] review denied: [Bug 256929] setSelectionRange will reset the m_latestFocusTrigger variable, causing the subsequently focused element to match the :focus-visible selector : [Attachment 466389] Like Element::focusForBindings, set the trigger to FocusTrigger::Bindings

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 5 13:09:30 PDT 2023


Ryosuke Niwa <rniwa at webkit.org> has denied 2471314 at gmail.com's request for
review:
Bug 256929: setSelectionRange will reset the m_latestFocusTrigger variable,
causing the subsequently focused element to match the :focus-visible selector
https://bugs.webkit.org/show_bug.cgi?id=256929

Attachment 466389: Like Element::focusForBindings, set the trigger to
FocusTrigger::Bindings

https://bugs.webkit.org/attachment.cgi?id=466389&action=review




--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 466389
  --> https://bugs.webkit.org/attachment.cgi?id=466389
Like Element::focusForBindings, set the trigger to FocusTrigger::Bindings

Thanks for the patch but this patch lacks appropriate commit message & a test,
both of which need to be added in order for this code change to land.


More information about the webkit-reviews mailing list