[webkit-reviews] review granted: [Bug 257685] [IFC] Remove redundant LineBuilder::computedIntrinsicWidth : [Attachment 466586] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jun 5 01:54:31 PDT 2023
Antti Koivisto <koivisto at iki.fi> has granted review:
Bug 257685: [IFC] Remove redundant LineBuilder::computedIntrinsicWidth
https://bugs.webkit.org/show_bug.cgi?id=257685
Attachment 466586: Patch
https://bugs.webkit.org/attachment.cgi?id=466586&action=review
--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 466586
--> https://bugs.webkit.org/attachment.cgi?id=466586
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=466586&action=review
>
Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp:431
> - auto intrinsicContent = lineBuilder.computedIntrinsicWidth({
layoutRange, { 0.f, 0.f, horizontalConstraints.logicalWidth, 0.f } },
previousLine);
> + auto lineLayoutResult = lineBuilder.layoutInlineContent({
layoutRange, { 0.f, 0.f, horizontalConstraints.logicalWidth, 0.f } },
previousLine);
nice!
More information about the webkit-reviews
mailing list