[webkit-reviews] review granted: [Bug 152663] AX: incorrect accessible name from multiple label elements : [Attachment 467053] Patch

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has granted  review:
Bug 152663: AX: incorrect accessible name from multiple label elements
https://bugs.webkit.org/show_bug.cgi?id=152663

Attachment 467053: Patch

https://bugs.webkit.org/attachment.cgi?id=467053&action=review




--- Comment #6 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 467053
  --> https://bugs.webkit.org/attachment.cgi?id=467053
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=467053&action=review

> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:248
> +    return labels.isEmpty() ? nullptr : labels.first();

does labels.first() return nil if it's empty anyway? or does it crash