[webkit-reviews] review granted: [Bug 259310] AX: VoiceOver only reading "link" for some lines when navigating via arrow up and down in contenteditables. : [Attachment 467069] Patch

[bugzilla-daemon at webkit.org]

Tyler Wilcock <tyler_w at apple.com> has granted Andres Gonzalez
<andresg_22 at apple.com>'s request for review:
Bug 259310: AX: VoiceOver only reading "link" for some lines when navigating
via arrow up and down in contenteditables.
https://bugs.webkit.org/show_bug.cgi?id=259310

Attachment 467069: Patch

https://bugs.webkit.org/attachment.cgi?id=467069&action=review




--- Comment #4 from Tyler Wilcock <tyler_w at apple.com> ---
Comment on attachment 467069
  --> https://bugs.webkit.org/attachment.cgi?id=467069
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=467069&action=review

> Source/WebCore/accessibility/isolatedtree/mac/AXIsolatedObjectMac.mm:191
>      auto attributedText =
propertyValue<RetainPtr<NSAttributedString>>(AXPropertyName::AttributedText);

Might be a micro-optimization not worth doing, but I don't think we need to
attempt to retrieve AXPropertyName::AttributedText from the map if !isConfined.