[webkit-reviews] review denied: [Bug 251223] AX: WebCore::AXIsolatedTree should use WTF::ThreadSafeRefCountedAndCanMakeThreadSafeWeakPtr<>. : [Attachment 464694] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Andres Gonzalez
<andresg_22 at apple.com>'s request for review:
Bug 251223: AX: WebCore::AXIsolatedTree should use
WTF::ThreadSafeRefCountedAndCanMakeThreadSafeWeakPtr<>.
https://bugs.webkit.org/show_bug.cgi?id=251223

Attachment 464694: Patch

https://bugs.webkit.org/attachment.cgi?id=464694&action=review




--- Comment #12 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 464694
  --> https://bugs.webkit.org/attachment.cgi?id=464694
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=464694&action=review

> Source/WebCore/accessibility/AXTreeStore.h:76
> +	   [&] (WeakPtr<AXObjectCache>& typedTree) {

This looks unnecessary.

> Source/WebCore/accessibility/AXTreeStore.h:85
> +	   [&] (ThreadSafeWeakPtr<AXIsolatedTree>& typedTree) {

ditto

> Source/WebCore/accessibility/AXTreeStore.h:94
> +	   [] (auto&) {

ditto