[webkit-reviews] review denied: [Bug 251223] AX: WebCore::AXIsolatedTree should use WTF::ThreadSafeRefCountedAndCanMakeThreadSafeWeakPtr<>. : [Attachment 464691] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Andres Gonzalez
<andresg_22 at apple.com>'s request for review:
Bug 251223: AX: WebCore::AXIsolatedTree should use
WTF::ThreadSafeRefCountedAndCanMakeThreadSafeWeakPtr<>.
https://bugs.webkit.org/show_bug.cgi?id=251223

Attachment 464691: Patch

https://bugs.webkit.org/attachment.cgi?id=464691&action=review




--- Comment #9 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 464691
  --> https://bugs.webkit.org/attachment.cgi?id=464691
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=464691&action=review

> Source/WebCore/accessibility/AXTreeStore.h:136
> +	   [] (ThreadSafeWeakPtr<AXIsolatedTree>& typedTree) -> AXIsolatedTree*
{ return typedTree.get().get(); },

This needs to return a RefPtr<AXIsolatedTree> otherwise it might immediately be
deleted by another thread.