[webkit-reviews] review denied: [Bug 251223] AX: WebCore::AXIsolatedTree should use WTF::ThreadSafeRefCountedAndCanMakeThreadSafeWeakPtr<>. : [Attachment 464681] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Andres Gonzalez
<andresg_22 at apple.com>'s request for review:
Bug 251223: AX: WebCore::AXIsolatedTree should use
WTF::ThreadSafeRefCountedAndCanMakeThreadSafeWeakPtr<>.
https://bugs.webkit.org/show_bug.cgi?id=251223

Attachment 464681: Patch

https://bugs.webkit.org/attachment.cgi?id=464681&action=review




--- Comment #6 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 464681
  --> https://bugs.webkit.org/attachment.cgi?id=464681
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=464681&action=review

> Source/WTF/wtf/ThreadSafeWeakPtr.h:104
> +    size_t strongRefCount() const

I don't think we should add this.  The value returned is immediately possibly
incorrect.  If we do add it, it should be inside ASSERT_ENABLED so we only use
it for assertions.