[webkit-reviews] review granted: [Bug 251045] AX: Fix for crash in AXIsolatedTree::removeNode. : [Attachment 464631] Patch

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has granted Andres Gonzalez
<andresg_22 at apple.com>'s request for review:
Bug 251045: AX: Fix for crash in AXIsolatedTree::removeNode.
https://bugs.webkit.org/show_bug.cgi?id=251045

Attachment 464631: Patch

https://bugs.webkit.org/attachment.cgi?id=464631&action=review




--- Comment #9 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 464631
  --> https://bugs.webkit.org/attachment.cgi?id=464631
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=464631&action=review

> COMMIT_MESSAGE:9
> +The crash happens in ITM because AXObjectCache::remove updates the isolated
tree by calling AXIsolatedTree::removeNode, that calls parentObjectUnignored(),
which results in a call to textUnderElement which cannot be called during a
layout. The solution in this patch is to make the removal of the object in
question asynchroniously.

spelling: asynchroniously