[webkit-reviews] review granted: [Bug 250099] AX: Conversion of PDFView coordinates to screen coordinates for accessibility should happen on the main thread. : [Attachment 464335] Patch

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has granted Andres Gonzalez
<andresg_22 at apple.com>'s request for review:
Bug 250099: AX: Conversion of PDFView coordinates to screen coordinates for
accessibility should happen on the main thread.
https://bugs.webkit.org/show_bug.cgi?id=250099

Attachment 464335: Patch

https://bugs.webkit.org/attachment.cgi?id=464335&action=review




--- Comment #3 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 464335
  --> https://bugs.webkit.org/attachment.cgi?id=464335
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=464335&action=review

> Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:2009
> +	   return
page->chrome().rootViewToScreen(enclosingIntRect(updatedRect));

return page ? page->chrome().rootViewToScreen(enclosingIntRect(updatedRect)); :
{ };

> Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:2025
> +	   return
page->chrome().rootViewToScreen(enclosingIntRect(rectInRootViewCoordinates));

return page ?
page->chrome().rootViewToScreen(enclosingIntRect(rectInRootViewCoordinates)) :
{ };