[webkit-reviews] review granted: [Bug 250094] run-jsc with the --debugger option should work with SIP enabled : [Attachment 464332] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 250094: run-jsc with the --debugger option should work with SIP enabled
https://bugs.webkit.org/show_bug.cgi?id=250094

Attachment 464332: Patch

https://bugs.webkit.org/attachment.cgi?id=464332&action=review




--- Comment #2 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 464332
  --> https://bugs.webkit.org/attachment.cgi?id=464332
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=464332&action=review

This somehow lacks a commit message?

> Tools/Scripts/run-jsc:56
>      $jsc = $debuggerCmd . " " . File::Spec->catfile(jscProductDir(), "jsc --
--useDollarVM=1 ") . "@ARGV";

Huh, this is not nice. "jsc -- --useDollarVM=1 " is not a path component. I'd
suggest improving this line while at it.

> Tools/Scripts/run-jsc:62
>  $ENV{"DYLD_FRAMEWORK_PATH"} = $dyld;

Is this still needed?