[webkit-reviews] review granted: [Bug 252593] Move RenderText::canUseSimplifiedTextMeasuring logic to TextUtil : [Attachment 465102] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 21 07:05:47 PST 2023


Antti Koivisto <koivisto at iki.fi> has granted  review:
Bug 252593: Move RenderText::canUseSimplifiedTextMeasuring logic to TextUtil
https://bugs.webkit.org/show_bug.cgi?id=252593

Attachment 465102: Patch

https://bugs.webkit.org/attachment.cgi?id=465102&action=review




--- Comment #4 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 465102
  --> https://bugs.webkit.org/attachment.cgi?id=465102
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=465102&action=review

> Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp:199
> +	   auto canUseSimplifiedTextMeasuring = canUseSimpleFontCodePath ?
Layout::TextUtil::canUseSimplifiedTextMeasuring(text, style,
firstLineStyle.get()) : false;

canUseSimpleFontCodePath &&
Layout::TextUtil::canUseSimplifiedTextMeasuring(text, style,
firstLineStyle.get())

is shorter.


More information about the webkit-reviews mailing list