[webkit-reviews] review granted: [Bug 252261] [Win] SHOULD NEVER BE REACHED: PrivateClickMeasurementDatabase.cpp(371) : WebKit::PCM::Database::allAttributedPrivateClickMeasurement : [Attachment 464986] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 14 14:04:04 PST 2023


Don Olmstead <don.olmstead at sony.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 252261: [Win] SHOULD NEVER BE REACHED:
PrivateClickMeasurementDatabase.cpp(371) :
WebKit::PCM::Database::allAttributedPrivateClickMeasurement
https://bugs.webkit.org/show_bug.cgi?id=252261

Attachment 464986: Patch

https://bugs.webkit.org/attachment.cgi?id=464986&action=review




--- Comment #3 from Don Olmstead <don.olmstead at sony.com> ---
Comment on attachment 464986
  --> https://bugs.webkit.org/attachment.cgi?id=464986
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=464986&action=review

> Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:219
> -#if PLATFORM(GTK) || PLATFORM(WPE)
> +#if PLATFORM(GTK) || PLATFORM(WPE) || PLATFORM(WIN)

Should this be `!PLATFORM(COCOA)`?


More information about the webkit-reviews mailing list