[webkit-reviews] review requested: [Bug 251849] AX: Remove unnecessary TextMrker methods from WebAccessibilityObjectWrapper. : [Attachment 464885] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 8 10:07:14 PST 2023


Darin Adler <darin at apple.com> has asked  for review:
Bug 251849: AX: Remove unnecessary TextMrker methods from
WebAccessibilityObjectWrapper.
https://bugs.webkit.org/show_bug.cgi?id=251849

Attachment 464885: Patch

https://bugs.webkit.org/attachment.cgi?id=464885&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 464885
  --> https://bugs.webkit.org/attachment.cgi?id=464885
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=464885&action=review

> COMMIT_MESSAGE:1
> +AX: Remove unnecessary TextMrker methods from WebAccessibilityObjectWrapper.


Typo here in TextMarker.

> Source/WebCore/accessibility/mac/AXObjectCacheMac.mm:535
> +	   [change setObject:marker.bridgingAutorelease()
forKey:NSAccessibilityTextChangeValueStartMarker];

Never need autorelease when passing a value to a method, only when returning.
Wastefully puts an object into the autorelease pool. Instead this should use
get() and bridge_cast. You can probably find an example by searching for
bridge_cast.


More information about the webkit-reviews mailing list