[webkit-reviews] review granted: [Bug 266357] [IFC][Ruby] Incorrect preferred width computation when <ruby> is present : [Attachment 469019] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Dec 13 10:57:15 PST 2023
Antti Koivisto <koivisto at iki.fi> has granted review:
Bug 266357: [IFC][Ruby] Incorrect preferred width computation when <ruby> is
present
https://bugs.webkit.org/show_bug.cgi?id=266357
Attachment 469019: Patch
https://bugs.webkit.org/attachment.cgi?id=469019&action=review
--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 469019
--> https://bugs.webkit.org/attachment.cgi?id=469019
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=469019&action=review
> Source/WebCore/rendering/RenderBlockFlow.cpp:4704
> +
rubyBaseMinimumMaximumWidthStack.append(std::make_pair(inlineMin, inlineMax));
I think you can alternatively just say std::pair { inlineMin, inlineMax },
make_pair is not necessary anymore.
More information about the webkit-reviews
mailing list