[webkit-reviews] review granted: [Bug 265881] [IFC][Ruby] Nested rubies with interlinear annotations pushes their ancestors' interlinear annotations vertically : [Attachment 468899] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted  review:
Bug 265881: [IFC][Ruby] Nested rubies with interlinear annotations pushes their
ancestors' interlinear annotations vertically
https://bugs.webkit.org/show_bug.cgi?id=265881

Attachment 468899: Patch

https://bugs.webkit.org/attachment.cgi?id=468899&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 468899
  --> https://bugs.webkit.org/attachment.cgi?id=468899
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=468899&action=review

>
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBui
lder.cpp:1101
> +	   auto placeAndSizeAnnotationBox = [&] {
> +	       auto visualBorderBoxTopLeft =
RubyFormattingContext::placeAnnotationBox(rubyBaseLayoutBox, baseMarginBoxRect,
formattingContext);
> +	       auto visualContentBoxSize =
RubyFormattingContext::sizeAnnotationBox(rubyBaseLayoutBox, formattingContext);
> +	       auto& annotationBoxGeometry =
formattingContext.geometryForBox(*annotationBox);
> +	      
annotationBoxGeometry.setTopLeft(toLayoutPoint(visualBorderBoxTopLeft));
> +	      
annotationBoxGeometry.setContentBoxSize(toLayoutSize(visualContentBoxSize));
> +	   };
> +	   placeAndSizeAnnotationBox();

so lambda