[webkit-reviews] review granted: [Bug 260776] [IFC] Use opaque InlineItem to compute out-of-flow static position : [Attachment 467478] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted  review:
Bug 260776: [IFC] Use opaque InlineItem to compute out-of-flow static position
https://bugs.webkit.org/show_bug.cgi?id=260776

Attachment 467478: Patch

https://bugs.webkit.org/attachment.cgi?id=467478&action=review




--- Comment #8 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 467478
  --> https://bugs.webkit.org/attachment.cgi?id=467478
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=467478&action=review

> COMMIT_MESSAGE:6
> +Let's replace existing out-of-flow handling with using opaque inline items
instead.

Nice!

>
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBui
lder.cpp:884
> +    auto formattingContext = this->formattingContext();

Does this purposefully create a copy of the formatting context?