[webkit-reviews] review granted: [Bug 260693] [IFC] Introduce InlineItem type 'opaque' : [Attachment 467447] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 25 18:52:31 PDT 2023


Antti Koivisto <koivisto at iki.fi> has granted  review:
Bug 260693: [IFC] Introduce InlineItem type 'opaque'
https://bugs.webkit.org/show_bug.cgi?id=260693

Attachment 467447: Patch

https://bugs.webkit.org/attachment.cgi?id=467447&action=review




--- Comment #4 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 467447
  --> https://bugs.webkit.org/attachment.cgi?id=467447
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=467447&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineItem.h:39
> -    enum class Type : uint8_t {
> +    enum class Type : uint16_t {

I don't think this enum type needs to grow. uint8_t does fit 9 values.


More information about the webkit-reviews mailing list