[webkit-reviews] review granted: [Bug 260454] [IFC] Add non-line-builder based minimum width computation : [Attachment 467352] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 21 08:50:18 PDT 2023


Antti Koivisto <koivisto at iki.fi> has granted  review:
Bug 260454: [IFC] Add non-line-builder based minimum width computation
https://bugs.webkit.org/show_bug.cgi?id=260454

Attachment 467352: Patch

https://bugs.webkit.org/attachment.cgi?id=467352&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 467352
  --> https://bugs.webkit.org/attachment.cgi?id=467352
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=467352&action=review

> COMMIT_MESSAGE:8
> +(This is a 4x speedup on
PerformanceTests/Layout/line-layout-preferred-width-break-all.html)

Not even 10x. Sad.

> Source/WebCore/layout/formattingContexts/inline/IntrinsicWidthHandler.cpp:39
> +static bool isEligibleForNonLineBuilderProcess(const RenderStyle& style)

A new process?


More information about the webkit-reviews mailing list