[webkit-reviews] review granted: [Bug 259900] [IFC] Add fast path for simple text only content : [Attachment 467226] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 10 08:10:23 PDT 2023


Antti Koivisto <koivisto at iki.fi> has granted  review:
Bug 259900: [IFC] Add fast path for simple text only content
https://bugs.webkit.org/show_bug.cgi?id=259900

Attachment 467226: Patch

https://bugs.webkit.org/attachment.cgi?id=467226&action=review




--- Comment #7 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 467226
  --> https://bugs.webkit.org/attachment.cgi?id=467226
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=467226&action=review

Very cool. SLL is back!

> Source/WebCore/layout/formattingContexts/inline/AbstractLineBuilder.h:101
> +class AbstractLineBuilder {
> +public:
> +    virtual LineLayoutResult layoutInlineContent(const LineInput&, const
std::optional<PreviousLine>&) = 0;
> +    virtual ~AbstractLineBuilder() { };
> +};

Maybe we could use a template instead of this at some point.


More information about the webkit-reviews mailing list