[webkit-reviews] review granted: [Bug 259952] AX: Initialize the AX thread on first client request. : [Attachment 467225] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 8 16:58:56 PDT 2023


Tyler Wilcock <tyler_w at apple.com> has granted Andres Gonzalez
<andresg_22 at apple.com>'s request for review:
Bug 259952: AX: Initialize the AX thread on first client request.
https://bugs.webkit.org/show_bug.cgi?id=259952

Attachment 467225: Patch

https://bugs.webkit.org/attachment.cgi?id=467225&action=review




--- Comment #3 from Tyler Wilcock <tyler_w at apple.com> ---
Comment on attachment 467225
  --> https://bugs.webkit.org/attachment.cgi?id=467225
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=467225&action=review

> Source/WebCore/accessibility/mac/AXObjectCacheMac.mm:719
> +    if (LIKELY(!isMainThread() || axThreadInitialized))

The latter check (axThreadInitialized) is cheaper, so maybe it should come
first?

if (LIKELY(axThreadInitialized || !isMainThread()))


More information about the webkit-reviews mailing list