[webkit-reviews] review granted: [Bug 259832] AX: Cache the ProcessID in the AXIsolatedTree so that it can be retrieved off the main thread. : [Attachment 467212] Patch

[bugzilla-daemon at webkit.org]

Tyler Wilcock <tyler_w at apple.com> has granted Andres Gonzalez
<andresg_22 at apple.com>'s request for review:
Bug 259832: AX: Cache the ProcessID in the AXIsolatedTree so that it can be
retrieved off the main thread.
https://bugs.webkit.org/show_bug.cgi?id=259832

Attachment 467212: Patch

https://bugs.webkit.org/attachment.cgi?id=467212&action=review




--- Comment #6 from Tyler Wilcock <tyler_w at apple.com> ---
Comment on attachment 467212
  --> https://bugs.webkit.org/attachment.cgi?id=467212
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=467212&action=review

> Source/WebCore/accessibility/AccessibilityObject.h:76
> +    ProcessID processID() const override;

Not necessary to spin a new patch, but seems like this could be `final` instead
of `override`.

> Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:54
> +    ProcessID processID() const override { return tree()->processID(); }

Not necessary to spin a new patch, but seems like this could be `final` instead
of `override`.