[webkit-reviews] review granted: [Bug 255845] AX: display:contents elements never return any selected AX children despite having them : [Attachment 466053] Patch

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has granted  review:
Bug 255845: AX: display:contents elements never return any selected AX children
despite having them
https://bugs.webkit.org/show_bug.cgi?id=255845

Attachment 466053: Patch

https://bugs.webkit.org/attachment.cgi?id=466053&action=review




--- Comment #4 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 466053
  --> https://bugs.webkit.org/attachment.cgi?id=466053
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=466053&action=review

> Source/WebCore/accessibility/AccessibilityObject.cpp:4107
> +	   return { };

wonder if we can put break; in all these places instead of early returns

then we can have just one final return { };

don't know if that's preferred in WebKit. generally early returns make me
nervous in case there's more cleanup that's supposed to happen at the end of a
method