[webkit-reviews] review granted: [Bug 255655] AX: Fix for hang in AXObjectCache::textMarkerDataForNextCharacterOffset. : [Attachment 465995] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Apr 19 18:28:07 PDT 2023
Darin Adler <darin at apple.com> has granted Andres Gonzalez
<andresg_22 at apple.com>'s request for review:
Bug 255655: AX: Fix for hang in
AXObjectCache::textMarkerDataForNextCharacterOffset.
https://bugs.webkit.org/show_bug.cgi?id=255655
Attachment 465995: Patch
https://bugs.webkit.org/attachment.cgi?id=465995&action=review
--- Comment #9 from Darin Adler <darin at apple.com> ---
Comment on attachment 465995
--> https://bugs.webkit.org/attachment.cgi?id=465995
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=465995&action=review
>> Source/WebCore/accessibility/AXObjectCache.cpp:2663
>> + if (characterOffset.isNull())
>
> This check seems to be unnecessary; the other check alone would fix the bug.
This check seems to be unnecessary; the other check alone would fix the bug.
>> Source/WebCore/accessibility/AXObjectCache.cpp:2700
>> + if (characterOffset.isNull())
>
> Same here.
Same here.
More information about the webkit-reviews
mailing list