[webkit-reviews] review granted: [Bug 255371] Make AXCoreObject::visibleChildren, AXCoreObject::isPresentationalChildOfAriaRole, and AXCoreObject::ariaRoleHasPresentationalChildren work for display:contents elements : [Attachment 465874] Patch

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has granted  review:
Bug 255371: Make AXCoreObject::visibleChildren,
AXCoreObject::isPresentationalChildOfAriaRole, and
AXCoreObject::ariaRoleHasPresentationalChildren work for display:contents
elements
https://bugs.webkit.org/show_bug.cgi?id=255371

Attachment 465874: Patch

https://bugs.webkit.org/attachment.cgi?id=465874&action=review




--- Comment #3 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 465874
  --> https://bugs.webkit.org/attachment.cgi?id=465874
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=465874&action=review

> Source/WebCore/accessibility/AccessibilityListBox.cpp:128
> +    for (unsigned i = 0; i < m_children.size(); i++) {

can we cache size() so we don't call it repeatedly on each iteration