[webkit-reviews] review granted: [Bug 255286] AX: Create TextMarkerRanges based on the TextContent of AXIsolatedObjects. : [Attachment 465847] Patch

[bugzilla-daemon at webkit.org]

Tyler Wilcock <tyler_w at apple.com> has granted Andres Gonzalez
<andresg_22 at apple.com>'s request for review:
Bug 255286: AX: Create TextMarkerRanges based on the TextContent of
AXIsolatedObjects.
https://bugs.webkit.org/show_bug.cgi?id=255286

Attachment 465847: Patch

https://bugs.webkit.org/attachment.cgi?id=465847&action=review




--- Comment #3 from Tyler Wilcock <tyler_w at apple.com> ---
Comment on attachment 465847
  --> https://bugs.webkit.org/attachment.cgi?id=465847
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=465847&action=review

Looks good to me once all EWS tests pass. I'd understand if you didn't want to
wait through another round of EWS just to fix some typos in the commit message,
up to you.

> COMMIT_MESSAGE:7
> +TextMarkerRanges were created using the cached AttributedString for some
types of AXIsoaltedObjects. However, we need to create TesxtMarkerRanges for
objects for which there is no cached AttributedString. This patch uses the
TextContent property instead of the cached AttributedString.

Typos:

AXIsoaltedObjects
TesxtMarkerRanges

> COMMIT_MESSAGE:11
> +This is needed to implement AXIsolatedObject::stringForTextMarkerRange and
related methods off the main thtread.

Typo: thtread