[webkit-reviews] review granted: [Bug 255138] AX: Eliminate all ways AXCoreObject::elementRect could be called on an AXIsolatedObject : [Attachment 465810] Patch

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has granted  review:
Bug 255138: AX: Eliminate all ways AXCoreObject::elementRect could be called on
an AXIsolatedObject
https://bugs.webkit.org/show_bug.cgi?id=255138

Attachment 465810: Patch

https://bugs.webkit.org/attachment.cgi?id=465810&action=review




--- Comment #5 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 465810
  --> https://bugs.webkit.org/attachment.cgi?id=465810
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=465810&action=review

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:1392
> +    return @(cgPoint);

do we need two lines of code here can can we do in one

also does @() turn this into a NSValue? I had always hoped it would, but don't
know if I tested it

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:1769
> +	   return [NSValue valueWithSize:NSMakeSize(size.width(),
size.height())];

is there no overload for

(NSValue *)backingObject->size()