[webkit-reviews] review granted: [Bug 244526] TextureMapper: Attach a depth buffer for BitmapTextureGL for 3D transform : [Attachment 462718] Patch

[bugzilla-daemon at webkit.org]

Don Olmstead <don.olmstead at sony.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 244526: TextureMapper: Attach a depth buffer for BitmapTextureGL for 3D
transform
https://bugs.webkit.org/show_bug.cgi?id=244526

Attachment 462718: Patch

https://bugs.webkit.org/attachment.cgi?id=462718&action=review




--- Comment #6 from Don Olmstead <don.olmstead at sony.com> ---
Comment on attachment 462718
  --> https://bugs.webkit.org/attachment.cgi?id=462718
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=462718&action=review

r=me with nits

> Source/WebCore/platform/graphics/texmap/BitmapTextureGL.h:45
> +#if OS(WINDOWS)
> +#define USE_TEXMAP_DEPTH_STENCIL_BUFFER 1
> +#else
> +#define USE_TEXMAP_DEPTH_STENCIL_BUFFER 0
> +#endif

>From your commit message it seems like this might be better to be `#if
USE(ANGLE)`?

Also I feel like this should be in a WTF header not just hanging out here.