[webkit-reviews] review granted: [Bug 244824] TextureMapper: rendering issue of a 3D transformed element at infinity with a parent with opacity<1 : [Attachment 462645] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 29 13:48:16 PDT 2022


Don Olmstead <don.olmstead at sony.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 244824: TextureMapper: rendering issue of a 3D transformed element at
infinity with a parent with opacity<1
https://bugs.webkit.org/show_bug.cgi?id=244824

Attachment 462645: Patch

https://bugs.webkit.org/attachment.cgi?id=462645&action=review




--- Comment #11 from Don Olmstead <don.olmstead at sony.com> ---
Comment on attachment 462645
  --> https://bugs.webkit.org/attachment.cgi?id=462645
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=462645&action=review

> Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:364
> +template<typename T>
> +struct Point4D {
> +    T x;
> +    T y;
> +    T z;
> +    T w;
> +};
> +
> +template<typename T>
> +Point4D<T> operator+(Point4D<T> s, Point4D<T> t)
> +{
> +    return { s.x + t.x, s.y + t.y, s.z + t.z, s.w + t.w };
> +}
> +
> +template<typename T>
> +Point4D<T> operator-(Point4D<T> s, Point4D<T> t)
> +{
> +    return { s.x - t.x, s.y - t.y, s.z - t.z, s.w - t.w };
> +}
> +
> +template<typename T>
> +Point4D<T> operator*(T s, Point4D<T> t)
> +{
> +    return { s * t.x, s * t.y, s * t.z, s * t.w };
> +}

I'm just surprised there's nothing hanging out already that you can piggy-back
on for this.


More information about the webkit-reviews mailing list