[webkit-reviews] review granted: [Bug 245694] AX: AXIsolatedTree::updateChildren doesn't propagate updates downwards when AccessibilityObject::m_subtreeDirty is true : [Attachment 462631] Patch

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has granted  review:
Bug 245694: AX: AXIsolatedTree::updateChildren doesn't propagate updates
downwards when AccessibilityObject::m_subtreeDirty is true
https://bugs.webkit.org/show_bug.cgi?id=245694

Attachment 462631: Patch

https://bugs.webkit.org/attachment.cgi?id=462631&action=review




--- Comment #4 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 462631
  --> https://bugs.webkit.org/attachment.cgi?id=462631
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=462631&action=review

> Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:598
> +	       if (auto* liveChild =
dynamicDowncast<AccessibilityObject>(newChildren[i].get()); liveChild &&
liveChild->hasDirtySubtree())

this is nice to string these in a single if. is this a new ability