[webkit-reviews] review granted: [Bug 245568] [LFC][Integration] Add a Layout::Box pointer to RenderObject : [Attachment 462559] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 23 06:33:04 PDT 2022


zalan <zalan at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s request
for review:
Bug 245568: [LFC][Integration] Add a Layout::Box pointer to RenderObject
https://bugs.webkit.org/show_bug.cgi?id=245568

Attachment 462559: Patch

https://bugs.webkit.org/attachment.cgi?id=462559&action=review




--- Comment #3 from zalan <zalan at apple.com> ---
Comment on attachment 462559
  --> https://bugs.webkit.org/attachment.cgi?id=462559
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=462559&action=review

v.nice!

> Source/WebCore/layout/layouttree/LayoutContainerBox.cpp:101
> +} 

trailing whitespace.

> Source/WebCore/rendering/RenderView.h:233
> +    std::unique_ptr<Layout::InitialContainingBlock>
m_initialContainingBlock;

can this be just a UniqueRef<> ?


More information about the webkit-reviews mailing list